linux-kernel - Re: [PATCH -next] powerpc/pmac: Make some symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8055476e-b7f9-f4b5-92f9-48d21eebba14@csgroup.eu>
Date:   Wed, 2 Mar 2022 13:23:08 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Zucheng Zheng <zhengzucheng@...wei.com>,
        "benh@...nel.crashing.org" <benh@...nel.crashing.org>,
        "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "paulus@...ba.org" <paulus@...ba.org>,
        "rppt@...nel.org" <rppt@...nel.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "oohall@...il.com" <oohall@...il.com>
CC:     "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] powerpc/pmac: Make some symbols static



Le 09/04/2021 à 11:38, Zucheng Zheng a écrit :
> ppc_override_l2cr/ppc_override_l2cr_value/has_l2cache symbol is not used
> outside of setup.c, so commit marks it static.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Zucheng Zheng <zhengzucheng@...wei.com>
> ---
>   arch/powerpc/platforms/powermac/setup.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/powermac/setup.c b/arch/powerpc/platforms/powermac/setup.c
> index 86aee3f2483f..db5107c80485 100644
> --- a/arch/powerpc/platforms/powermac/setup.c
> +++ b/arch/powerpc/platforms/powermac/setup.c
> @@ -71,9 +71,9 @@
>   
>   #undef SHOW_GATWICK_IRQS
>   
> -int ppc_override_l2cr = 0;
> -int ppc_override_l2cr_value;
> -int has_l2cache = 0;
> +static int ppc_override_l2cr;
> +static int ppc_override_l2cr_value;
> +static int has_l2cache;
>   
>   int pmac_newworld;
>   

With ppc64_defconfig,

   CC      arch/powerpc/platforms/powermac/setup.o
arch/powerpc/platforms/powermac/setup.c:75:12: error: 
'ppc_override_l2cr_value' defined but not used [-Werror=unused-variable]
    75 | static int ppc_override_l2cr_value;
       |            ^~~~~~~~~~~~~~~~~~~~~~~
arch/powerpc/platforms/powermac/setup.c:74:12: error: 
'ppc_override_l2cr' defined but not used [-Werror=unused-variable]
    74 | static int ppc_override_l2cr;
       |            ^~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[3]: *** [scripts/Makefile.build:288: 
arch/powerpc/platforms/powermac/setup.o] Error 1


You have to move it inside the #ifdef CONFIG_PPC32 block that uses it.

Christophe