linux-kernel - Re: [PATCH v2] parport_pc: Also enable driver for PCI systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2203021337430.58475@angie.orcam.me.uk>
Date:   Wed, 2 Mar 2022 13:45:22 +0000 (GMT)
From:   "Maciej W. Rozycki" <macro@...am.me.uk>
To:     Icenowy Zheng <icenowy@...c.io>
cc:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, Guo Ren <guoren@...nel.org>,
        Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Jeff Dike <jdike@...toit.com>,
        Richard Weinberger <richard@....at>,
        Anton Ivanov <anton.ivanov@...bridgegreys.com>,
        Chris Zankel <chris@...kel.net>,
        Max Filippov <jcmvbkbc@...il.com>,
        linux-arm-kernel@...ts.infradead.org, linux-csky@...r.kernel.org,
        linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org,
        linux-um@...ts.infradead.org, linux-xtensa@...ux-xtensa.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] parport_pc: Also enable driver for PCI systems

On Wed, 2 Mar 2022, Icenowy Zheng wrote:

> > The only PCI platforms that actually can't make use of PC-style
> > parallel 
> > port hardware are those newer PCIe systems that have no support for
> > I/O 
> > cycles in the host bridge, required by such parallel ports.  Notably,
> > this includes the s390 arch, which has port I/O accessors that cause 
> > compilation warnings (promoted to errors with `-Werror'), and there
> > are 
> > other cases such as the POWER9 PHB4 device, though this one has
> > variable 
> > port I/O accessors that depend on the particular system.  Also it is
> > not 
> > clear whether the serial port side of devices enabled by
> > PARPORT_SERIAL 
> > uses port I/O or MMIO.  Finally Super I/O solutions are always either
> > ISA or platform devices.
> 
> Just spot this patch in linux-riscv mailing list, I think there's a
> pending patchset that tries to add a HAS_IOPORT Kconfig option, which
> can be used in this situation.

 Thanks for your input.

 That has been actually discussed already with a conclusion that more work 
is required to have HAS_IOPORT supported, see the thread starting from: 
<https://lore.kernel.org/lkml/CAMuHMdW-utcFzCZTgqONjxs=U662nF0=aBQu7Zi7FBQouwiA3g@mail.gmail.com/>. 
(there's a reference to the HAS_IOPORT patchset there as well).  Once that 
has been sorted configuration conditions for the parport driver can be 
updated accordingly.  For the time being the !S390 qualification should 
do.

  Maciej