linux-kernel - Re: [PATCH] dpaa2 ethernet switch driver: Fix memory leak in dpaa2_switch_acl_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220301181456.3678a4b0@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 1 Mar 2022 18:14:56 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Q1IQ <fufuyqqqqqq@...il.com>
Cc:     ioana.ciornei@....com, davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, lyz_cs@....edu.cn
Subject: Re: [PATCH] dpaa2 ethernet switch driver: Fix memory leak in
 dpaa2_switch_acl_entry_remove()

On Tue,  1 Mar 2022 17:24:50 +0800 Q1IQ wrote:
> @@ -182,6 +183,7 @@ dpaa2_switch_acl_entry_remove(struct dpaa2_switch_filter_block *block,
>  			 DMA_TO_DEVICE);
>  	if (err) {
>  		dev_err(dev, "dpsw_acl_remove_entry() failed %d\n", err);
> +		kfree(cmd_buff);
>  		return err;
>  	}

Same comments apply to this patch as to the other patch you sent.