linux-kernel - Re: [PATCH] net: arcnet: com20020: Fix null-ptr-deref in com20020pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220301182855.40d4282d@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 1 Mar 2022 18:28:55 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Zheyu Ma <zheyuma97@...il.com>
Cc:     m.grzeschik@...gutronix.de, davem@...emloft.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: arcnet: com20020: Fix null-ptr-deref in
 com20020pci_probe()

On Mon, 28 Feb 2022 11:44:13 +0000 Zheyu Ma wrote:
> During driver initialization, the pointer of card info, i.e. the
> variable 'ci' is required. However, the definition of
> 'com20020pci_id_table' reveals that this field is empty for some
> devices, which will cause null pointer dereference when initializing
> these devices.
> 
> The following log reveals it:
> 
> [    3.973806] KASAN: null-ptr-deref in range [0x0000000000000028-0x000000000000002f]
> [    3.973819] RIP: 0010:com20020pci_probe+0x18d/0x13e0 [com20020_pci]
> [    3.975181] Call Trace:
> [    3.976208]  local_pci_probe+0x13f/0x210
> [    3.977248]  pci_device_probe+0x34c/0x6d0
> [    3.977255]  ? pci_uevent+0x470/0x470
> [    3.978265]  really_probe+0x24c/0x8d0
> [    3.978273]  __driver_probe_device+0x1b3/0x280
> [    3.979288]  driver_probe_device+0x50/0x370
> 
> Fix this by checking whether the 'ci' is a null pointer first.

Can we get a Fixes tag pointing to the commit where the problem was
introduced?