linux-kernel - Re: [PATCH v3 00/30] Driver for Hyper-v virtual compute device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220302145339.2s2bt252sxj3lsn6@liuwe-devbox-debian-v2>
Date:   Wed, 2 Mar 2022 14:53:39 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Iouri Tarassov <iourit@...ux.microsoft.com>
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        wei.liu@...nel.org, linux-hyperv@...r.kernel.org,
        linux-kernel@...r.kernel.org, spronovo@...rosoft.com,
        spronovo@...ux.microsoft.com, gregkh@...uxfoundation.org
Subject: Re: [PATCH v3 00/30] Driver for Hyper-v virtual compute device

Hi Iouri

I've gone through the whole series. A large portion of the series is
about graphics stuff which is out of my wheelhouse.

I have two general comments here.

There seems to be an excessive amount pr_debug / pr_err in code. Please
try to reduce their number a bit.

For memory allocation you always use vzalloc, however large or small the
allocation may be. Why not use kzalloc for smaller allocations?

Thanks,
Wei.