linux-kernel - Re: [PATCH] config: Using HOSTPKG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220302102705.15c32822@gandalf.local.home>
Date:   Wed, 2 Mar 2022 10:27:05 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     Chun-Tse Shao <ctshao@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Frank Rowand <frowand.list@...il.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] config: Using HOSTPKG_CONFIG prefix for pkg-config

On Wed, 2 Mar 2022 08:18:15 -0600
Rob Herring <robh+dt@...nel.org> wrote:

> On Tue, Mar 1, 2022 at 5:07 PM Chun-Tse Shao <ctshao@...gle.com> wrote:
> >
> > In some parts, pkg-config does not use appropriate $BUILDROOT prefix.  
> 
> The kernel tree knows nothing about buildroot. Please reword this in a
> more generic way that you need to override the host pkg-config.

I don't even know what $BUILDROOT is ;-)

But I do know that it's good practice to allow pkg-config to be overridden.
I have several user space tools that needed it done to allow distros to
install them properly.

Would you be OK with a description like:

    Allow kernel installation packaging to override pkg-config.

?

> 
> > The patch adds HOSTPKG_CONFIG prefix for pkg-config to fix the issue.

A couple of things. It is consider poor form to reference "the patch".
Another thing is that this is not a prefix for pkg-config, it is overriding
what pkg-config is used during the build process.

    Add HOSTPKG_CONFIG to allow tooling that builds the kernel to override
    what pkg-config and parameters are used.

Something like that.

-- Steve



> >
> > Signed-off-by: Chun-Tse Shao <ctshao@...gle.com>