lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Yh+Qw6Pb+Cd9JDNa@smile.fi.intel.com> Date: Wed, 2 Mar 2022 17:44:03 +0200 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: Michael Mueller <mimu@...ux.ibm.com>, Yury Norov <yury.norov@...il.com> Cc: Claudio Imbrenda <imbrenda@...ux.ibm.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>, kvm@...r.kernel.org, linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org, Janosch Frank <frankja@...ux.ibm.com>, David Hildenbrand <david@...hat.com>, Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>, Alexander Gordeev <agordeev@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com> Subject: Re: [PATCH v1 1/1] KVM: s390: Don't cast parameter in bit operations On Thu, Feb 24, 2022 at 01:10:34PM +0100, Michael Mueller wrote: > On 24.02.22 12:36, Claudio Imbrenda wrote: ... > we do that at several places Thanks for pointing out. > arch/s390/kernel/processor.c: for_each_set_bit_inv(bit, (long > *)&stfle_fac_list, MAX_FACILITY_BIT) This one requires a separate change, not related to this patch. > arch/s390/kvm/interrupt.c: set_bit_inv(IPM_BIT_OFFSET + gisc, (unsigned long > *) gisa); This is done in the patch. Not sure how it appears in your list. > arch/s390/kvm/kvm-s390.c: set_bit_inv(vcpu->vcpu_id, (unsigned long *) > sca->mcn); > arch/s390/kvm/kvm-s390.c: set_bit_inv(vcpu->vcpu_id, (unsigned long *) > &sca->mcn); These two should be fixed in a separate change. Also this kind of stuff: bitmap_copy(kvm->arch.cpu_feat, (unsigned long *) data.feat, KVM_S390_VM_CPU_FEAT_NR_BITS); might require a new API like bitmap_from_u64_array() bitmap_to_u64_array() Yury? -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists