linux-kernel - Re: [PATCH v1 1/3] auxdisplay: lcd2s: Fix lcd2s_redefine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yh+RfBIeC5huOvsA@smile.fi.intel.com>
Date:   Wed, 2 Mar 2022 17:47:08 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Miguel Ojeda <ojeda@...nel.org>,
        Lars Poeschel <poeschel@...onage.de>
Subject: Re: [PATCH v1 1/3] auxdisplay: lcd2s: Fix lcd2s_redefine_char()
 feature

On Wed, Feb 23, 2022 at 05:47:16PM +0200, Andy Shevchenko wrote:
> It seems that the lcd2s_redefine_char() has never been properly
> tested. The buffer is filled by DEF_CUSTOM_CHAR command followed
> by the character number (from 0 to 7), but immediately after that
> these bytes are got rewritten by the decoded hex stream.
> 
> Fix the index to fill the buffer after the command and number.

Any comments on this, please? There are fixes and seems auxdisplay subsystem
is a bit lagging... Should we worry about?

-- 
With Best Regards,
Andy Shevchenko