linux-kernel - Re: [PATCH v1 1/1] media: c8sectpfe: Clean up handling of *_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yh+SjmGgSZGGaW/I@smile.fi.intel.com>
Date:   Wed, 2 Mar 2022 17:51:42 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Patrice Chotard <patrice.chotard@...s.st.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v1 1/1] media: c8sectpfe: Clean up handling of
 *_buffer_aligned

On Wed, Feb 09, 2022 at 08:25:21PM +0200, Andy Shevchenko wrote:
> There are a few cases where code is harder than needed to read.
> Improve those by:
> - dropping unnecessary castings (see note below)
> - use PTR_ALING() to be more explicit on what's going on there
> - use proper definitions instead of hard coded values
> 
> Note, dropping castings will allow to perform an additional check
> that type is not changed from void * to something else, e.g. u64,
> which may very well break the bitmap APIs.

Any comments on it?
Can it be applied?

-- 
With Best Regards,
Andy Shevchenko