lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4001045b-c404-763d-d1ba-41f6ed05ff8b@csgroup.eu>
Date:   Wed, 2 Mar 2022 17:08:32 +0100
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Nour-eddine Taleb <1337.noureddine@...il.com>, paulus@...abs.org,
        mpe@...erman.id.au, benh@...nel.crashing.org
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        kvm-ppc@...r.kernel.org
Subject: Re: [PATCH] arch: powerpc: kvm: remove unnecessary casting



Le 09/05/2021 à 14:00, Nour-eddine Taleb a écrit :
> remove unnecessary castings, from "void *" to "struct kvmppc_xics *"
> 
> Signed-off-by: Nour-eddine Taleb <1337.noureddine@...il.com>

This patch doesn't apply. Tabs are broken, they've been replaced by 4 
space chars.

> ---
>   arch/powerpc/kvm/book3s_xics.c        | 2 +-
>   arch/powerpc/kvm/book3s_xive.c        | 2 +-
>   arch/powerpc/kvm/book3s_xive_native.c | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/kvm/book3s_xics.c b/arch/powerpc/kvm/book3s_xics.c
> index 303e3cb096db..9ae74fa551a6 100644
> --- a/arch/powerpc/kvm/book3s_xics.c
> +++ b/arch/powerpc/kvm/book3s_xics.c
> @@ -1440,7 +1440,7 @@ static int kvmppc_xics_create(struct kvm_device
> *dev, u32 type)
> 
>   static void kvmppc_xics_init(struct kvm_device *dev)
>   {
> -    struct kvmppc_xics *xics = (struct kvmppc_xics *)dev->private;
> +    struct kvmppc_xics *xics = dev->private;
> 
>       xics_debugfs_init(xics);
>   }
> diff --git a/arch/powerpc/kvm/book3s_xive.c b/arch/powerpc/kvm/book3s_xive.c
> index e7219b6f5f9a..05bcaf81a90a 100644
> --- a/arch/powerpc/kvm/book3s_xive.c
> +++ b/arch/powerpc/kvm/book3s_xive.c
> @@ -2242,7 +2242,7 @@ static void xive_debugfs_init(struct kvmppc_xive *xive)
> 
>   static void kvmppc_xive_init(struct kvm_device *dev)
>   {
> -    struct kvmppc_xive *xive = (struct kvmppc_xive *)dev->private;
> +    struct kvmppc_xive *xive = dev->private;
> 
>       /* Register some debug interfaces */
>       xive_debugfs_init(xive);
> diff --git a/arch/powerpc/kvm/book3s_xive_native.c
> b/arch/powerpc/kvm/book3s_xive_native.c
> index 76800c84f2a3..2703432cea78 100644
> --- a/arch/powerpc/kvm/book3s_xive_native.c
> +++ b/arch/powerpc/kvm/book3s_xive_native.c
> @@ -1265,7 +1265,7 @@ static void xive_native_debugfs_init(struct
> kvmppc_xive *xive)
> 
>   static void kvmppc_xive_native_init(struct kvm_device *dev)
>   {
> -    struct kvmppc_xive *xive = (struct kvmppc_xive *)dev->private;
> +    struct kvmppc_xive *xive = dev->private;
> 
>       /* Register some debug interfaces */
>       xive_native_debugfs_init(xive);

Powered by blists - more mailing lists