lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220302162622.z5wxbdmxh2pqh6cb@maple.lan> Date: Wed, 2 Mar 2022 16:26:22 +0000 From: Daniel Thompson <daniel.thompson@...aro.org> To: Aaron Tomlin <atomlin@...hat.com> Cc: mcgrof@...nel.org, christophe.leroy@...roup.eu, pmladek@...e.com, cl@...ux.com, mbenes@...e.cz, akpm@...ux-foundation.org, jeyu@...nel.org, linux-kernel@...r.kernel.org, linux-modules@...r.kernel.org, void@...ifault.com, atomlin@...mlin.com, allen.lkml@...il.com, joe@...ches.com, msuchanek@...e.de, oleksandr@...alenko.name, jason.wessel@...driver.com Subject: Re: [PATCH v9 13/14] module: Move kdb_modules list out of core code On Wed, Mar 02, 2022 at 04:19:17PM +0000, Daniel Thompson wrote: > On Mon, Feb 28, 2022 at 11:43:21PM +0000, Aaron Tomlin wrote: > > No functional change. > > > > This patch migrates kdb_modules list to core kdb code > > since the list of added/or loaded modules is no longer > > private. > > > > Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu> > > Signed-off-by: Aaron Tomlin <atomlin@...hat.com> > > --- > > kernel/debug/kdb/kdb_main.c | 5 +++++ > > kernel/debug/kdb/kdb_private.h | 4 ---- > > kernel/module/main.c | 4 ---- > > 3 files changed, 5 insertions(+), 8 deletions(-) > > > > diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c > > index 0852a537dad4..5369bf45c5d4 100644 > > --- a/kernel/debug/kdb/kdb_main.c > > +++ b/kernel/debug/kdb/kdb_main.c > > @@ -59,6 +59,11 @@ EXPORT_SYMBOL(kdb_grepping_flag); > > int kdb_grep_leading; > > int kdb_grep_trailing; > > > > +#ifdef CONFIG_MODULES > > +extern struct list_head modules; Actually thinking a bit harder and trying `git grep '#include .*[.][.]' kernel/` (which finds some prior art) I wonder if we even want the extern or whether `#include "../../module/internal.h"` would be more robust. Daniel. > > +static struct list_head *kdb_modules = &modules; /* kdb needs the list of modules */ > > If modules is no longer static then why do we kdb_modules at all? > kdb_modules is used exactly once and it can now simply be replaced > with &modules. > > > Daniel.
Powered by blists - more mailing lists