linux-kernel - Re: [PATCH v2] config: Allow kernel installation packaging to override pkg-config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Mar 2022 10:41:21 -0800
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Steven Rostedt <rostedt@...dmis.org>,
        Chun-Tse Shao <ctshao@...gle.com>
Cc:     devicetree@...r.kernel.org, frowand.list@...il.com,
        jpoimboe@...hat.com, linux-kbuild@...r.kernel.org,
        linux-kernel@...r.kernel.org, masahiroy@...nel.org,
        michal.lkml@...kovi.net, peterz@...radead.org, robh+dt@...nel.org
Subject: Re: [PATCH v2] config: Allow kernel installation packaging to
 override pkg-config

On Thu, Mar 3, 2022 at 4:42 AM Steven Rostedt <rostedt@...dmis.org> wrote:
>
> On Wed, 2 Mar 2022 13:48:01 -0800
> Nick Desaulniers <ndesaulniers@...gle.com> wrote:
>
> > I'm ok with this patch; a quick grep though shows a few more open
> > coded instances of pkg-config.  Should we fix those up, too? i.e.
> >
> > certs/Makefile:92:HOSTCFLAGS_extract-cert.o = $(shell pkg-config
> > --cflags libcrypto 2> /dev/null)
> > certs/Makefile:93:HOSTLDLIBS_extract-cert = $(shell pkg-config --libs
> > libcrypto 2> /dev/null || echo -lcrypto)
> > scripts/kconfig/gconf-cfg.sh
>
> For this patch set, the above is probably good enough to do (and test
> with a make allmodconfig).
>
> > tools/perf/Makefile.perf
> > tools/ in general
>
> I would hold off on doing tools for a separate patch. With the
> exception of objtool most of tools is not needed for the build process.

SGTM

-- 
Thanks,
~Nick Desaulniers