linux-kernel - [PATCH] Fixed function pointers coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu,  3 Mar 2022 21:11:20 +0200
From:   hatimmohammed369@...il.com
To:     pbonzini@...hat.com
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hatim Muhammed <hatimmohammed369@...il.com>
Subject: [PATCH] Fixed function pointers coding style issues

From: Hatim Muhammed <hatimmohammed369@...il.com>

Signed-off-by: Hatim Muhammed <hatimmohammed369@...il.com>

Some functions pointers did not provide names for their parameters,
     Fixed that

---
 virt/kvm/vfio.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/virt/kvm/vfio.c b/virt/kvm/vfio.c
index 8fcbc50221c2..37887b158aae 100644
--- a/virt/kvm/vfio.c
+++ b/virt/kvm/vfio.c
@@ -35,7 +35,7 @@ struct kvm_vfio {
 static struct vfio_group *kvm_vfio_group_get_external_user(struct file *filep)
 {
 	struct vfio_group *vfio_group;
-	struct vfio_group *(*fn)(struct file *);
+	struct vfio_group *(*fn)(struct file *_file);
 
 	fn = symbol_get(vfio_group_get_external_user);
 	if (!fn)
@@ -66,7 +66,7 @@ static bool kvm_vfio_external_group_match_file(struct vfio_group *group,
 
 static void kvm_vfio_group_put_external_user(struct vfio_group *vfio_group)
 {
-	void (*fn)(struct vfio_group *);
+	void (*fn)(struct vfio_group *_vfio_group);
 
 	fn = symbol_get(vfio_group_put_external_user);
 	if (!fn)
@@ -79,7 +79,7 @@ static void kvm_vfio_group_put_external_user(struct vfio_group *vfio_group)
 
 static void kvm_vfio_group_set_kvm(struct vfio_group *group, struct kvm *kvm)
 {
-	void (*fn)(struct vfio_group *, struct kvm *);
+	void (*fn)(struct vfio_group *_vfio_group, struct kvm *_kvm);
 
 	fn = symbol_get(vfio_group_set_kvm);
 	if (!fn)
@@ -92,7 +92,7 @@ static void kvm_vfio_group_set_kvm(struct vfio_group *group, struct kvm *kvm)
 
 static bool kvm_vfio_group_is_coherent(struct vfio_group *vfio_group)
 {
-	long (*fn)(struct vfio_group *, unsigned long);
+	long (*fn)(struct vfio_group *_vfio_group, unsigned long _n);
 	long ret;
 
 	fn = symbol_get(vfio_external_check_extension);
@@ -109,7 +109,7 @@ static bool kvm_vfio_group_is_coherent(struct vfio_group *vfio_group)
 #ifdef CONFIG_SPAPR_TCE_IOMMU
 static int kvm_vfio_external_user_iommu_id(struct vfio_group *vfio_group)
 {
-	int (*fn)(struct vfio_group *);
+	int (*fn)(struct vfio_group *_vfio_group);
 	int ret = -EINVAL;
 
 	fn = symbol_get(vfio_external_user_iommu_id);
-- 
2.35.1