linux-kernel - Re: [PATCH 2/2] kselftest/vm: fix tests build with old libc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Mar 2022 14:27:41 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Chengming Zhou <zhouchengming@...edance.com>,
        akpm@...ux-foundation.org, shuah@...nel.org
Cc:     linux-mm@...ck.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 2/2] kselftest/vm: fix tests build with old libc

On 2/26/22 10:53 PM, Chengming Zhou wrote:
> The error message when I build vm tests on debian10 (GLIBC 2.28):
> 
> userfaultfd.c: In function ‘userfaultfd_pagemap_test’:
> userfaultfd.c:1393:37: error: ‘MADV_PAGEOUT’ undeclared (first use
> in this function); did you mean ‘MADV_RANDOM’?
>    if (madvise(area_dst, test_pgsize, MADV_PAGEOUT))
>                                       ^~~~~~~~~~~~
>                                       MADV_RANDOM
> 
> This patch includes these newer definitions from UAPI linux/mman.h,
> is useful to fix tests build on systems without these definitions in
> glibc sys/mman.h.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@...edance.com>
> ---
>   tools/testing/selftests/vm/userfaultfd.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/selftests/vm/userfaultfd.c
> index 2f49c9af1b58..3fc1d2ee2948 100644
> --- a/tools/testing/selftests/vm/userfaultfd.c
> +++ b/tools/testing/selftests/vm/userfaultfd.c
> @@ -46,6 +46,7 @@
>   #include <signal.h>
>   #include <poll.h>
>   #include <string.h>
> +#include <linux/mman.h>
>   #include <sys/mman.h>
>   #include <sys/syscall.h>
>   #include <sys/ioctl.h>
> 

Looks good to me.

Andrew,

If you want to take this through your tree or I can apply it.

Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah