linux-kernel - Re: [PATCH] drm/nouveau/instmem: fix uninitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 03 Mar 2022 17:09:00 -0500
From:   Lyude Paul <lyude@...hat.com>
To:     Guo Zhengkui <guozhengkui@...o.com>,
        Ben Skeggs <bskeggs@...hat.com>,
        Karol Herbst <kherbst@...hat.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" 
        <dri-devel@...ts.freedesktop.org>,
        "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" 
        <nouveau@...ts.freedesktop.org>,
        "moderated list:ARM/STM32 ARCHITECTURE" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "moderated list:ARM/STM32 ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/nouveau/instmem: fix uninitialized_var.cocci warning

Reviewed-by: Lyude Paul <lyude@...hat.com>

Will push this to the appropriate drm-misc repository in just a little bit

On Mon, 2022-02-28 at 22:23 +0800, Guo Zhengkui wrote:
> Fix following coccicheck warning:
> drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c:316:11-12:
> WARNING this kind of initialization is deprecated.
> 
> `void *map = map` has the same form of
> uninitialized_var() macro. I remove the redundant assignement. It has
> been tested with gcc (Debian 8.3.0-6) 8.3.0.
> 
> The patch which removed uninitialized_var() is:
> https://lore.kernel.org/all/20121028102007.GA7547@gmail.com/
> And there is very few "/* GCC */" comments in the Linux kernel code now.
> 
> Signed-off-by: Guo Zhengkui <guozhengkui@...o.com>
> ---
>  drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c
> b/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c
> index 96aca0edfa3c..c51bac76174c 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c
> @@ -313,7 +313,7 @@ nv50_instobj_dtor(struct nvkm_memory *memory)
>         struct nv50_instobj *iobj = nv50_instobj(memory);
>         struct nvkm_instmem *imem = &iobj->imem->base;
>         struct nvkm_vma *bar;
> -       void *map = map;
> +       void *map;
>  
>         mutex_lock(&imem->mutex);
>         if (likely(iobj->lru.next))

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat