linux-kernel - Re: [PATCH] drm: Fix no previous prototype error in drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 2 Mar 2022 22:24:01 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Aashish Sharma <shraash@...gle.com>
Cc:     Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, linux-kernel@...r.kernel.org,
        groeck@...omium.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm: Fix no previous prototype error in drm_nomodeset.c

On Wed, Mar 02, 2022 at 10:39:02PM +0530, Aashish Sharma wrote:
> Fix this kernel test robot error:
> 
> drivers/gpu/drm/drm_nomodeset.c:8:6: error:
> no previous prototype for 'drm_firmware_drivers_only'
> 
> Including drm_drv.h in drm_nomodeset.c which contains
> drm_firmware_drivers_only's declaration.
> 
> Signed-off-by: Aashish Sharma <shraash@...gle.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/gpu/drm/drm_nomodeset.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/drm_nomodeset.c b/drivers/gpu/drm/drm_nomodeset.c
> index f3978d5bd3a1..9402deb4985f 100644
> --- a/drivers/gpu/drm/drm_nomodeset.c
> +++ b/drivers/gpu/drm/drm_nomodeset.c
> @@ -2,6 +2,7 @@
>  
>  #include <linux/module.h>
>  #include <linux/types.h>
> +#include <drm/drm_drv.h>
>  
>  static bool drm_nomodeset;
>  
> -- 
> 2.35.1.574.g5d30c73bfb-goog
>