linux-kernel - [PATCH] firmware: tee_bnxt: remove redundant assignment to variable nbytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu,  3 Mar 2022 09:15:21 +0000
From:   Colin Ian King <colin.i.king@...il.com>
To:     Rafał Miłecki <zajec5@...il.com>,
        linux-mips@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] firmware: tee_bnxt: remove redundant assignment to variable nbytes

The variable nbytes is assigned a value that is never read, it is
being re-assigned a new value on the following statement. The
assignmen is redundant and can be removed.

Cleans up cppcheck warning:
drivers/firmware/broadcom/tee_bnxt_fw.c:148:10: style: Variable 'nbytes'
is reassigned a value before the old one has been used.
[redundantAssignment]

Signed-off-by: Colin Ian King <colin.i.king@...il.com>
---
 drivers/firmware/broadcom/tee_bnxt_fw.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index a5bf4c3f6dc7..6d92ec02f2c7 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size)
 	prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param);
 
 	while (rbytes)  {
-		nbytes = rbytes;
-
 		nbytes = min_t(u32, rbytes, param[0].u.memref.size);
 
 		/* Fill additional invoke cmd params */
-- 
2.34.1