linux-kernel - Re: [PATCH v2] USB: serial: pl2303: Add IBM device IDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YiCHPuNkMuO4uARu@hovoldconsulting.com>
Date:   Thu, 3 Mar 2022 10:15:42 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Joel Stanley <joel@....id.au>
Cc:     Eddie James <eajames@...ux.ibm.com>, linux-usb@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v2] USB: serial: pl2303: Add IBM device IDs

On Thu, Mar 03, 2022 at 08:52:29AM +0000, Joel Stanley wrote:
> On Thu, 3 Mar 2022 at 08:25, Johan Hovold <johan@...nel.org> wrote:
> >
> > On Tue, Mar 01, 2022 at 04:44:46PM -0600, Eddie James wrote:
> > > IBM manufactures a PL2303 device for UPS communications. Add the vendor
> > > and product IDs so that the PL2303 driver binds to the device.
> > >
> > > Signed-off-by: Joel Stanley <joel@....id.au>
> > > Signed-off-by: Eddie James <eajames@...ux.ibm.com>
> > > ---
> > > Changes since v1:
> > >  - Fix commit message Signed-off-by ordering.
> >
> > Almost there. You're still missing a Co-developed-by tag, a From line,
> > or both.
> 
> It's neither. This patch was applied to a tree by myself, and I asked
> Eddie to send it to mainline for merging.

Then you are missing a From line. As the patch looks like know, Eddie is
considered the author and not you.

> Given it's come through me, and now has been sent to you, I think the
> chain of s-o-b is appropriate.

So the chain of SoB is correct, but the authorship is not.

You can use git-format-patch and git-send-email to avoid this kind of
problems, but just manually inserting a From line in the body of the
mail works too.

Johan