linux-kernel - Re: [PATCH v2] i2c: busses: i2c-mt65xx: Simplify with clk-bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22eccb9e-45fa-683e-640d-6f34fa63ca52@collabora.com>
Date:   Thu, 3 Mar 2022 10:25:22 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     qii.wang@...iatek.com
Cc:     matthias.bgg@...il.com, linux-i2c@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com, wsa@...nel.org,
        Qii Wang <wii.wang@...iatek.com>
Subject: Re: [PATCH v2] i2c: busses: i2c-mt65xx: Simplify with clk-bulk

Il 03/03/22 10:15, AngeloGioacchino Del Regno ha scritto:
> Since depending on the SoC or specific bus functionality some clocks
> may be optional, we cannot get the benefit of using devm_clk_bulk_get()
> but, by migrating to clk-bulk, we are able to remove the custom functions
> mtk_i2c_clock_enable() and mtk_i2c_clock_disable(), increasing common
> APIs usage, hence (lightly) decreasing kernel footprint.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> Reviewed-by: Qii Wang <wii.wang@...iatek.com>
> ---
> 
> v2: Rebased on top of wsa/linux.git branch i2c/for-mergewindow
> 
>   drivers/i2c/busses/i2c-mt65xx.c | 124 +++++++++++++-------------------
>   1 file changed, 51 insertions(+), 73 deletions(-)
> 
Hello Wolfram,

I'm sorry but in this v2 I have typoed Qii Wang's email
(qii.wang <at> mediatek.com).

Please, can you fix that while applying, or should I send a v3?

Sorry again and thank you,
Angelo