linux-kernel - Re: [PATCH] video: fbdev: s3c-fb: fix platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cdeb8c40-1861-ac1e-338f-6ffdd6ddddb9@gmx.de>
Date:   Thu, 3 Mar 2022 11:15:20 +0100
From:   Helge Deller <deller@....de>
To:     Yihao Han <hanyihao@...o.com>, Jingoo Han <jingoohan1@...il.com>,
        linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Cc:     kernel@...o.com
Subject: Re: [PATCH] video: fbdev: s3c-fb: fix platform_get_irq.cocci warning

On 3/2/22 04:44, Yihao Han wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
>
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>
> Signed-off-by: Yihao Han <hanyihao@...o.com>

applied to the fbdev for-next git tree.

Thanks!
Helge

> ---
>  drivers/video/fbdev/s3c-fb.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
> index 208514054c23..3abbc5737c3b 100644
> --- a/drivers/video/fbdev/s3c-fb.c
> +++ b/drivers/video/fbdev/s3c-fb.c
> @@ -1418,7 +1418,6 @@ static int s3c_fb_probe(struct platform_device *pdev)
>
>  	sfb->irq_no = platform_get_irq(pdev, 0);
>  	if (sfb->irq_no < 0) {
> -		dev_err(dev, "failed to acquire irq resource\n");
>  		ret = -ENOENT;
>  		goto err_lcd_clk;
>  	}