linux-kernel - Re: [Intel-gfx] [PATCH] drm/i915/selftests: check the return value of kstrdup()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0jSHMkSNuyjEKGtDBdmpLcQS8-r_ZevR0d2iVTGEVvUmKV3g@mail.gmail.com>
Date:   Thu, 3 Mar 2022 11:15:45 +0000
From:   Matthew Auld <matthew.william.auld@...il.com>
To:     xkernel.wang@...mail.com
Cc:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        Intel Graphics Development <intel-gfx@...ts.freedesktop.org>,
        kernel list <linux-kernel@...r.kernel.org>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: check the return value of kstrdup()

On Thu, 3 Mar 2022 at 10:53, Matthew Auld
<matthew.william.auld@...il.com> wrote:
>
> On Tue, 22 Feb 2022 at 13:32, <xkernel.wang@...mail.com> wrote:
> >
> > From: Xiaoke Wang <xkernel.wang@...mail.com>
> >
> > kstrdup() is a memory allocation function which can return NULL when
> > some internaly memory errors happen. It is better to check the return
> > value of it to prevent further wrong memory access.
> >
> > Signed-off-by: Xiaoke Wang <xkernel.wang@...mail.com>
> Reviewed-by: Matthew Auld <matthew.auld@...el.com>

Scratch that. it looks like the for() already accounts for this, as
pointed out by Chris.