linux-kernel - [netfilter-nf-next:master 8/12] net/netfilter/nf_conntrack_netlink.c:1817:15: error: implicit declaration of function 'nf_conn_pernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 3 Mar 2022 19:41:59 +0800
From:   kernel test robot <lkp@...el.com>
To:     Florian Westphal <fw@...len.de>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org,
        Pablo Neira Ayuso <pablo@...filter.org>
Subject: [netfilter-nf-next:master 8/12]
 net/netfilter/nf_conntrack_netlink.c:1817:15: error: implicit declaration of
 function 'nf_conn_pernet_ecache'

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-next.git master
head:   25485ffb54ac073e82957218404e303469477c2f
commit: 78babcd3d89c2de2bc8ba688faa4f6d64d82f7ff [8/12] netfilter: conntrack: include ecache dying list in dumps
config: riscv-randconfig-r042-20220303 (https://download.01.org/0day-ci/archive/20220303/202203031953.bHVCmKKO-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d271fc04d5b97b12e6b797c6067d3c96a8d7470e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-next.git/commit/?id=78babcd3d89c2de2bc8ba688faa4f6d64d82f7ff
        git remote add netfilter-nf-next git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-next.git
        git fetch --no-tags netfilter-nf-next master
        git checkout 78babcd3d89c2de2bc8ba688faa4f6d64d82f7ff
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash net/netfilter/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

>> net/netfilter/nf_conntrack_netlink.c:1817:15: error: implicit declaration of function 'nf_conn_pernet_ecache' [-Werror,-Wimplicit-function-declaration]
           ecache_net = nf_conn_pernet_ecache(net);
                        ^
>> net/netfilter/nf_conntrack_netlink.c:1817:13: warning: incompatible integer to pointer conversion assigning to 'struct nf_conntrack_net_ecache *' from 'int' [-Wint-conversion]
           ecache_net = nf_conn_pernet_ecache(net);
                      ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
   net/netfilter/nf_conntrack_netlink.c:3941:2: error: implicit declaration of function 'nf_conntrack_register_notifier' [-Werror,-Wimplicit-function-declaration]
           nf_conntrack_register_notifier(&ctnl_notifier);
           ^
   net/netfilter/nf_conntrack_netlink.c:3941:2: note: did you mean 'netlink_register_notifier'?
   include/linux/netlink.h:151:5: note: 'netlink_register_notifier' declared here
   int netlink_register_notifier(struct notifier_block *nb);
       ^
   net/netfilter/nf_conntrack_netlink.c:3941:34: error: use of undeclared identifier 'ctnl_notifier'; did you mean 'rtnl_notify'?
           nf_conntrack_register_notifier(&ctnl_notifier);
                                           ^~~~~~~~~~~~~
                                           rtnl_notify
   include/linux/rtnetlink.h:14:13: note: 'rtnl_notify' declared here
   extern void rtnl_notify(struct sk_buff *skb, struct net *net, u32 pid,
               ^
   1 warning and 3 errors generated.


vim +/nf_conn_pernet_ecache +1817 net/netfilter/nf_conntrack_netlink.c

  1802	
  1803	static int
  1804	ctnetlink_dump_dying(struct sk_buff *skb, struct netlink_callback *cb)
  1805	{
  1806		struct ctnetlink_list_dump_ctx *ctx = (void *)cb->ctx;
  1807		struct nf_conntrack_net_ecache *ecache_net;
  1808		const struct net *net = sock_net(skb->sk);
  1809		struct nf_conn *last = ctx->last;
  1810		struct nf_conntrack_tuple_hash *h;
  1811		struct hlist_nulls_node *n;
  1812	
  1813		if (ctx->retrans_done)
  1814			return ctnetlink_dump_list(skb, cb, true);
  1815	
  1816		ctx->last = NULL;
> 1817		ecache_net = nf_conn_pernet_ecache(net);
  1818		spin_lock_bh(&ecache_net->dying_lock);
  1819	
  1820		hlist_nulls_for_each_entry(h, n, &ecache_net->dying_list, hnnode) {
  1821			struct nf_conn *ct;
  1822			int res;
  1823	
  1824			ct = nf_ct_tuplehash_to_ctrack(h);
  1825			if (last && last != ct)
  1826				continue;
  1827	
  1828			res = ctnetlink_dump_one_entry(skb, cb, ct, true);
  1829			if (res < 0) {
  1830				spin_unlock_bh(&ecache_net->dying_lock);
  1831				nf_ct_put(last);
  1832				return skb->len;
  1833			}
  1834	
  1835			nf_ct_put(last);
  1836			last = NULL;
  1837		}
  1838	
  1839		ctx->retrans_done = true;
  1840		spin_unlock_bh(&ecache_net->dying_lock);
  1841		nf_ct_put(last);
  1842	
  1843		return ctnetlink_dump_list(skb, cb, true);
  1844	}
  1845	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org