linux-kernel - Re: [PATCH 00/16] staging: r8188eu: convert functions to return bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 3 Mar 2022 15:20:03 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Vihas Makwana <makvihas@...il.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Straube <straube.linux@...il.com>,
        Martin Kaiser <martin@...ser.cx>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/16] staging: r8188eu: convert functions to return bool

On Thu, Mar 03, 2022 at 02:17:21AM +0530, Vihas Makwana wrote:
> There are many functions which return true/false but are marked as int, 
> uint, s32 etc. Mark them as bool.
> 
> Vihas Makwana (16):
>   staging: r8188eu: mark rtw_is_cckrates_included as bool
>   staging: r8188eu: mark rtw_is_cckratesonly_included as bool
>   staging: r8188eu: mark rtw_is_desired_network as bool
>   staging: r8188eu: mark PS_RDY_CHECK as bool
>   staging: r8188eu: mark check_indicate_seq as bool
>   staging: r8188eu: mark enqueue_reorder_recvframe as bool
>   staging: r8188eu: mark recv_indicatepkts_in_order as bool
>   staging: r8188eu: mark cckrates_included as bool
>   staging: r8188eu: mark cckratesonly_included as bool
>   staging: r8188eu: mark is_basicrate as bool
>   staging: r8188eu: mark is_ap_in_tkip as bool
>   staging: r8188eu: mark rtl8188eu_xmitframe_complete as bool
>   staging: r8188eu: mark check_fwstate as bool
>   staging: r8188eu: mark IS_MCAST as bool
>   staging: r8188eu: mark IsFrameTypeCtrl as bool
>   staging: r8188eu: mark rtw_endofpktfile as bool
> 

Looks good.  Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

regards,
dan carpenter