lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <PH0PR03MB678602F6E1B491B2A882BC7C99049@PH0PR03MB6786.namprd03.prod.outlook.com> Date: Thu, 3 Mar 2022 13:34:00 +0000 From: "Sa, Nuno" <Nuno.Sa@...log.com> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> CC: Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de> Subject: RE: [PATCH v1 1/1] iio: dac: ltc2688: Use temporary variable for struct device > From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> > Sent: Wednesday, March 2, 2022 4:32 PM > To: Sa, Nuno <Nuno.Sa@...log.com>; Andy Shevchenko > <andriy.shevchenko@...ux.intel.com>; linux-iio@...r.kernel.org; > linux-kernel@...r.kernel.org > Cc: Jonathan Cameron <jic23@...nel.org>; Lars-Peter Clausen > <lars@...afoo.de> > Subject: [PATCH v1 1/1] iio: dac: ltc2688: Use temporary variable for > struct device > > [External] > > Use temporary variable for struct device to make code neater. > > Signed-off-by: Andy Shevchenko > <andriy.shevchenko@...ux.intel.com> > --- Reviewed-by: Nuno Sá <nuno.sa@...log.com> > drivers/iio/dac/ltc2688.c | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) > > diff --git a/drivers/iio/dac/ltc2688.c b/drivers/iio/dac/ltc2688.c > index e41861d29767..d249fa28202c 100644 > --- a/drivers/iio/dac/ltc2688.c > +++ b/drivers/iio/dac/ltc2688.c > @@ -703,21 +703,20 @@ static int ltc2688_tgp_clk_setup(struct > ltc2688_state *st, > struct ltc2688_chan *chan, > struct fwnode_handle *node, int tgp) > { > + struct device *dev = &st->spi->dev; > unsigned long rate; > struct clk *clk; > int ret, f; > > - clk = devm_get_clk_from_child(&st->spi->dev, > to_of_node(node), NULL); > + clk = devm_get_clk_from_child(dev, to_of_node(node), > NULL); > if (IS_ERR(clk)) > - return dev_err_probe(&st->spi->dev, PTR_ERR(clk), > - "failed to get tgp clk.\n"); > + return dev_err_probe(dev, PTR_ERR(clk), "failed to get > tgp clk.\n"); > > ret = clk_prepare_enable(clk); > if (ret) > - return dev_err_probe(&st->spi->dev, ret, > - "failed to enable tgp clk.\n"); > + return dev_err_probe(dev, ret, "failed to enable tgp > clk.\n"); > > - ret = devm_add_action_or_reset(&st->spi->dev, > ltc2688_clk_disable, clk); > + ret = devm_add_action_or_reset(dev, ltc2688_clk_disable, > clk); > if (ret) > return ret; > > @@ -858,6 +857,7 @@ static int ltc2688_channel_config(struct > ltc2688_state *st) > > static int ltc2688_setup(struct ltc2688_state *st, struct regulator *vref) > { > + struct device *dev = &st->spi->dev; > struct gpio_desc *gpio; > int ret; > > @@ -865,10 +865,9 @@ static int ltc2688_setup(struct ltc2688_state > *st, struct regulator *vref) > * If we have a reset pin, use that to reset the board, If not, use > * the reset bit. > */ > - gpio = devm_gpiod_get_optional(&st->spi->dev, "clr", > GPIOD_OUT_HIGH); > + gpio = devm_gpiod_get_optional(dev, "clr", > GPIOD_OUT_HIGH); > if (IS_ERR(gpio)) > - return dev_err_probe(&st->spi->dev, PTR_ERR(gpio), > - "Failed to get reset gpio"); > + return dev_err_probe(dev, PTR_ERR(gpio), "Failed to > get reset gpio"); > if (gpio) { > usleep_range(1000, 1200); > /* bring device out of reset */ > @@ -887,7 +886,7 @@ static int ltc2688_setup(struct ltc2688_state *st, > struct regulator *vref) > * Duplicate the default channel configuration as it can change > during > * @ltc2688_channel_config() > */ > - st->iio_chan = devm_kmemdup(&st->spi->dev, > ltc2688_channels, > + st->iio_chan = devm_kmemdup(dev, ltc2688_channels, > sizeof(ltc2688_channels), > GFP_KERNEL); > if (!st->iio_chan) > return -ENOMEM; > -- > 2.34.1
Powered by blists - more mailing lists