linux-kernel - Re: [PATCH v1 3/3] auxdisplay: lcd2s: Use proper API to free the instance of charlcd object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Mar 2022 02:19:44 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Miguel Ojeda <ojeda@...nel.org>,
        Lars Poeschel <poeschel@...onage.de>
Subject: Re: [PATCH v1 3/3] auxdisplay: lcd2s: Use proper API to free the
 instance of charlcd object

On Wed, Feb 23, 2022 at 4:47 PM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> While it might work, the current approach is fragile in a few ways:
> - whenever members in the structure are shuffled, the pointer will be wrong
> - the resource freeing may include more than covered by kfree()
>
> Fix this by using charlcd_free() call instead of kfree().
>
> Fixes: 8c9108d014c5 ("auxdisplay: add a driver for lcd2s character display")
> Cc: Lars Poeschel <poeschel@...onage.de>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Thanks Andy, queued.

Cheers,
Miguel