linux-kernel - Re: [PATCH v3 3/3] iio: temperature: ltc2983: Make use of device properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Mar 2022 16:23:33 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Sa, Nuno" <Nuno.Sa@...log.com>
Cc:     "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v3 3/3] iio: temperature: ltc2983: Make use of device
 properties

On Thu, Mar 03, 2022 at 01:31:56PM +0000, Sa, Nuno wrote:

...

> > +	ref = fwnode_find_reference(child, "adi,cold-junction-
> > handle", 0);
> > +	if (ref) {
> 
> This is nok. It needs to be 'if (IS_ERR(ref))'. We then should return
> ERR_CAST() in case of errors inside the if block.

This is a good catch!

> As this reference
> is also optional, we need to nullify ref in case we don't find the
> it. Otherwise fwnode_handle_put() breaks.

No, this is not correct. fwnode_handle_put() is ERR_PTR aware.

> We also need to use ptr error logic in the other places where
> fwnode_find_reference() is used. Although, in the other cases
> the ref is mandatory, so there's no need to care with breaking
> fwnode_handle_put().
> 
> After these changes (I think the changes are straight enough;
> but I can re-test if you or Jonathan ask for it):
> 
> Tested-by: Nuno Sá <nuno.sa@...log.com>
> 

-- 
With Best Regards,
Andy Shevchenko