linux-kernel - Re: [PATCH v2] mips: DEC: honor CONFIG_MIPS_FP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2203041614260.47558@angie.orcam.me.uk>
Date:   Fri, 4 Mar 2022 16:17:41 +0000 (GMT)
From:   "Maciej W. Rozycki" <macro@...am.me.uk>
To:     Randy Dunlap <rdunlap@...radead.org>
cc:     linux-kernel@...r.kernel.org, patches@...ts.linux.dev,
        kernel test robot <lkp@...el.com>,
        Paul Burton <paulburton@...nel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-mips@...r.kernel.org
Subject: Re: [PATCH v2] mips: DEC: honor CONFIG_MIPS_FP_SUPPORT=n

On Fri, 4 Mar 2022, Randy Dunlap wrote:

> --- linux-next-20220303.orig/arch/mips/dec/setup.c
> +++ linux-next-20220303/arch/mips/dec/setup.c
> @@ -746,6 +746,7 @@ void __init arch_init_irq(void)
>  		dec_interrupt[DEC_IRQ_HALT] = -1;
>  
>  	/* Register board interrupts: FPU and cascade. */
> +#if defined(CONFIG_MIPS_FP_SUPPORT)
>  	if (dec_interrupt[DEC_IRQ_FPU] >= 0 && cpu_has_fpu) {
>  		struct irq_desc *desc_fpu;
>  		int irq_fpu;

 Can you please make it:

	if (IS_ENABLED(CONFIG_MIPS_FP_SUPPORT) && 
	    dec_interrupt[DEC_IRQ_FPU] >= 0 && cpu_has_fpu) {

so as not to add more #ifdef's where avoidable?

  Maciej