linux-kernel - Re: [PATCH] PCI: dwc: solve returning success but actually failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqKKj5znW1z7Oyk03O1qLVADUNRC5GthoVcM37HajHnxBA@mail.gmail.com>
Date:   Fri, 4 Mar 2022 11:10:33 -0600
From:   Rob Herring <robh@...nel.org>
To:     "Zhangjiantao(Kirin,Nanjing)" <water.zhangjiantao@...wei.com>
Cc:     "jingoohan1@...il.com" <jingoohan1@...il.com>,
        "gustavo.pimentel@...opsys.com" <gustavo.pimentel@...opsys.com>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "kw@...ux.com" <kw@...ux.com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Caiyadong <caiyadong@...wei.com>,
        guhengsheng <guhengsheng@...ilicon.com>,
        "zhangjianrong (E)" <zhangjianrong5@...wei.com>
Subject: Re: [PATCH] PCI: dwc: solve returning success but actually failed

On Fri, Mar 4, 2022 at 6:06 AM Zhangjiantao(Kirin,Nanjing)
<water.zhangjiantao@...wei.com> wrote:
>

For the subject, something like: 'PCI: dwc: Fix setting error return
on MSI DMA mapping failure'

> When dma_mapping_error returns error because of no enough memory available, dw_pcie_host_init will return success, which will mislead the callers.

Wrap lines at 72 char.

>

Add a Fixes tag with whatever commit introduced the problem.

> Signed-off-by: zhangjianrong <zhangjianrong5@...wei.com>
> Signed-off-by: zhangjiantao <water.zhangjiantao@...wei.com>

Author and S-o-b names should match.

>
> ---
>   drivers/pci/controller/dwc/pcie-designware-host.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c
> b/drivers/pci/controller/dwc/pcie-designware-host.c
> index f4755f3a03be..ac691d733848 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> @@ -393,6 +393,7 @@ int dw_pcie_host_init(struct pcie_port *pp)
>               if (dma_mapping_error(pci->dev, pp->msi_data)) {
>                   dev_err(pci->dev, "Failed to map MSI data\n");
>                   pp->msi_data = 0;
> +                ret = -1;

Use an errno value. ENOMEM seems to be common, but I also see EIO and
EFAULT used.

Rob