linux-kernel - RE: [PATCH] arm64: hyperv: make the format of 'Hyper-V: Host Build' output match x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN0PR21MB309826D5A9E262A65E0E07F9D7059@MN0PR21MB3098.namprd21.prod.outlook.com>
Date:   Fri, 4 Mar 2022 18:22:25 +0000
From:   "Michael Kelley (LINUX)" <mikelley@...rosoft.com>
To:     vkuznets <vkuznets@...hat.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>
CC:     KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] arm64: hyperv: make the format of 'Hyper-V: Host Build'
 output match x86

From: Vitaly Kuznetsov <vkuznets@...hat.com> Sent: Friday, March 4, 2022 4:24 AM
> 
> Currently, the following is observed on Hyper-V/ARM:
> 
>  Hyper-V: Host Build 10.0.22477.1061-1-0
> 
> This differs from similar output on x86:
> 
>  Hyper-V Host Build:20348-10.0-1-0.1138
> 
> and this is inconvenient. As x86 was the first to introduce the current
> format and to not break existing tools parsing it, change the format on
> ARM to match.

Interesting.  I had explicitly output this line differently on ARM64 so
that the output is in the standard form of a Windows version number,
which is what the Host Build value actually is.  My intent is to fix the
x86 side as well.  I had not anticipated there being automated parsing
of these strings.

I had also put the colon in the place to be consistent with most
other Hyper-V messages.  I know:  picky, picky. :-)

What's the impact of changing the tools that parse it so that
either version could be handled?

Michael

> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> ---
>  arch/arm64/hyperv/mshyperv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/hyperv/mshyperv.c b/arch/arm64/hyperv/mshyperv.c
> index bbbe351e9045..7b9c1c542a77 100644
> --- a/arch/arm64/hyperv/mshyperv.c
> +++ b/arch/arm64/hyperv/mshyperv.c
> @@ -60,8 +60,8 @@ static int __init hyperv_init(void)
>  	b = result.as32.b;
>  	c = result.as32.c;
>  	d = result.as32.d;
> -	pr_info("Hyper-V: Host Build %d.%d.%d.%d-%d-%d\n",
> -		b >> 16, b & 0xFFFF, a,	d & 0xFFFFFF, c, d >> 24);
> +	pr_info("Hyper-V Host Build:%d-%d.%d-%d-%d.%d\n",
> +		a, b >> 16, b & 0xFFFF, c, d >> 24, d & 0xFFFFFF);
> 
>  	ret = hv_common_init();
>  	if (ret)
> --
> 2.35.1