linux-kernel - Re: [PATCH v4 2/6] selftests/resctrl: Change the default limited time to 120 seconds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YiJ6ZUgiQNAYn+ZR@otcwcpicx3.sc.intel.com>
Date:   Fri, 4 Mar 2022 12:45:25 -0800
From:   Fenghua Yu <fenghua.yu@...el.com>
To:     Shaopeng Tan <tan.shaopeng@...fujitsu.com>
Cc:     Reinette Chatre <reinette.chatre@...el.com>,
        Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v4 2/6] selftests/resctrl: Change the default limited
 time to 120 seconds

Hi, Shaopeng,

On Fri, Mar 04, 2022 at 07:38:30PM +0900, Shaopeng Tan wrote:
> When testing on a Intel(R) Xeon(R) Gold 6254 CPU @ 3.10GHz the resctrl
> selftests fail due to timeout after exceeding the default time limit of
> 45 seconds. On this system the test takes about 68 seconds.
> Since the failing test by default accesses a fixed size of memory, the
> execution time should not vary significantly between different environment.
> A new default of 120 seconds should be sufficient yet easy to customize
> with the introduction of the "settings" file for reference.
> 
> Reviewed-by: Shuah Khan <skhan@...uxfoundation.org>
> Signed-off-by: Shaopeng Tan <tan.shaopeng@...fujitsu.com>
> ---
>  tools/testing/selftests/resctrl/settings | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 tools/testing/selftests/resctrl/settings
> 
> diff --git a/tools/testing/selftests/resctrl/settings b/tools/testing/selftests/resctrl/settings
> new file mode 100644
> index 000000000000..6091b45d226b
> --- /dev/null
> +++ b/tools/testing/selftests/resctrl/settings
> @@ -0,0 +1 @@

Maybe add some comments here?

+# If running time is longer than 120 seconds when new tests are added in 
+# the future, increase timeout here.

> +timeout=120
> -- 
> 2.27.0
> 
Thanks.

-Fenghua