linux-kernel - Re: [PATCH -next] power: supply: da9150-fg: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 4 Mar 2022 22:13:11 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     support.opensource@...semi.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] power: supply: da9150-fg: Remove unnecessary print
 function dev_err()

Hi,

On Tue, Mar 01, 2022 at 04:16:19PM +0800, Yang Li wrote:
> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
> 
> Eliminate the follow coccicheck warning:
> ./drivers/power/supply/da9150-fg.c:524:2-9: line 524 is redundant
> because platform_get_irq() already prints an error
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/da9150-fg.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/power/supply/da9150-fg.c b/drivers/power/supply/da9150-fg.c
> index e63fa62d1943..8c5e2c49d6c1 100644
> --- a/drivers/power/supply/da9150-fg.c
> +++ b/drivers/power/supply/da9150-fg.c
> @@ -520,10 +520,8 @@ static int da9150_fg_probe(struct platform_device *pdev)
>  
>  	/* Register IRQ */
>  	irq = platform_get_irq_byname(pdev, "FG");
> -	if (irq < 0) {
> -		dev_err(dev, "Failed to get IRQ FG: %d\n", irq);
> +	if (irq < 0)
>  		return irq;
> -	}
>  
>  	ret = devm_request_threaded_irq(dev, irq, NULL, da9150_fg_irq,
>  					IRQF_ONESHOT, "FG", fg);
> -- 
> 2.20.1.7.g153144c
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)