linux-kernel - Re: [PATCH] power: supply: ab8500: Remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 4 Mar 2022 22:24:52 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] power: supply: ab8500: Remove unused variable

Hi,

On Tue, Mar 01, 2022 at 10:58:50AM +0530, Souptick Joarder wrote:
> From: "Souptick Joarder (HPE)" <jrdr.linux@...il.com>
> 
> Kernel test robot reported below warning ->
> drivers/power/supply/ab8500_chargalg.c:790:13: warning:
> variable 'delta_i_ua' set but not used [-Wunused-but-set-variable]
> 
> Remove unused variable delta_i_ua.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Souptick Joarder (HPE) <jrdr.linux@...il.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/ab8500_chargalg.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/power/supply/ab8500_chargalg.c b/drivers/power/supply/ab8500_chargalg.c
> index b5a3096e78a1..f73d29c09caf 100644
> --- a/drivers/power/supply/ab8500_chargalg.c
> +++ b/drivers/power/supply/ab8500_chargalg.c
> @@ -793,13 +793,10 @@ static void init_maxim_chg_curr(struct ab8500_chargalg *di)
>   */
>  static enum maxim_ret ab8500_chargalg_chg_curr_maxim(struct ab8500_chargalg *di)
>  {
> -	int delta_i_ua;
>  
>  	if (!di->bm->maxi->ena_maxi)
>  		return MAXIM_RET_NOACTION;
>  
> -	delta_i_ua = di->ccm.original_iset_ua - di->batt_data.inst_curr_ua;
> -
>  	if (di->events.vbus_collapsed) {
>  		dev_dbg(di->dev, "Charger voltage has collapsed %d\n",
>  				di->ccm.wait_cnt);
> -- 
> 2.25.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)