linux-kernel - RE: [PATCH -next] clocksource/drivers/imx-tpm: Move tpm_read_sched_clock() under CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Mar 2022 00:56:57 +0000
From:   Peng Fan <peng.fan@....com>
To:     Nathan Chancellor <nathan@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>
CC:     Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "patches@...ts.linux.dev" <patches@...ts.linux.dev>
Subject: RE: [PATCH -next] clocksource/drivers/imx-tpm: Move
 tpm_read_sched_clock() under CONFIG_ARM

> Subject: [PATCH -next] clocksource/drivers/imx-tpm: Move
> tpm_read_sched_clock() under CONFIG_ARM
> 
> When building this driver for an architecture other than ARCH=arm:
> 
>   drivers/clocksource/timer-imx-tpm.c:78:20: error: unused function
> 'tpm_read_sched_clock' [-Werror,-Wunused-function]
>   static u64 notrace tpm_read_sched_clock(void)
>                      ^
>   1 error generated.
> 
> Move the function definition under the existing CONFIG_ARM section so there
> is no more warning.
> 
> Fixes: 10720e120e2b ("clocksource/drivers/imx-tpm: Exclude sched clock for
> ARM64")
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>

Reviewed-by: Peng Fan <peng.fan@....com>

> ---
>  drivers/clocksource/timer-imx-tpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/timer-imx-tpm.c
> b/drivers/clocksource/timer-imx-tpm.c
> index 60cefc247b71..bd64a8a8427f 100644
> --- a/drivers/clocksource/timer-imx-tpm.c
> +++ b/drivers/clocksource/timer-imx-tpm.c
> @@ -73,12 +73,12 @@ static unsigned long tpm_read_current_timer(void)
> {
>  	return tpm_read_counter();
>  }
> -#endif
> 
>  static u64 notrace tpm_read_sched_clock(void)  {
>  	return tpm_read_counter();
>  }
> +#endif
> 
>  static int tpm_set_next_event(unsigned long delta,
>  				struct clock_event_device *evt)
> 
> base-commit: b22a1c270f533e30bc5d5d4cab6199a2cbb07b07
> --
> 2.35.1