linux-kernel - RE: [EXT] [PATCH -next] drm/fsl-dcu: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM9PR04MB89078D8090D1FAD28BCB48F5F4059@AM9PR04MB8907.eurprd04.prod.outlook.com>
Date:   Fri, 4 Mar 2022 08:29:23 +0000
From:   Alison Wang <alison.wang@....com>
To:     Yang Li <yang.lee@...ux.alibaba.com>
CC:     "stefan@...er.ch" <stefan@...er.ch>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: RE: [EXT] [PATCH -next] drm/fsl-dcu: Remove unnecessary print
 function dev_err()

Acked-by: Alison Wang <alison.wang@....com>


Best Regards,
Alison Wang


-----Original Message-----
From: Yang Li <yang.lee@...ux.alibaba.com> 
Sent: 2022年3月3日 10:30
To: Alison Wang <alison.wang@....com>
Cc: stefan@...er.ch; airlied@...ux.ie; daniel@...ll.ch; dri-devel@...ts.freedesktop.org; linux-kernel@...r.kernel.org; Yang Li <yang.lee@...ux.alibaba.com>; Abaci Robot <abaci@...ux.alibaba.com>
Subject: [EXT] [PATCH -next] drm/fsl-dcu: Remove unnecessary print function dev_err()

Caution: EXT Email

The print function dev_err() is redundant because platform_get_irq() already prints an error.

Eliminate the follow coccicheck warning:
./drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c:277:2-9: line 277 is redundant because platform_get_irq() already prints an error

Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
---
 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
index 7a503bf08d0f..20895ea79739 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
@@ -273,10 +273,8 @@ static int fsl_dcu_drm_probe(struct platform_device *pdev)
        }

        fsl_dev->irq = platform_get_irq(pdev, 0);
-       if (fsl_dev->irq < 0) {
-               dev_err(dev, "failed to get irq\n");
+       if (fsl_dev->irq < 0)
                return fsl_dev->irq;
-       }

        fsl_dev->regmap = devm_regmap_init_mmio(dev, base,
                        &fsl_dcu_regmap_config);
--[Alison Wang] r
2.20.1.7.g153144c