linux-kernel - [PATCH] Input: synaptics: change initialization error into warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri,  4 Mar 2022 11:40:55 +0100
From:   David Heidelberg <david@...t.cz>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     David Heidelberg <david@...t.cz>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] Input: synaptics: change initialization error into warning

Since touchpad work on Dell XPS 9360 as expected while using
Synopsys DesignWare driver, let's assume
warning about not loading driver can be lowered from error to warning.

Lower in some cases useless errors like these to warnings:
psmouse serio1: synaptics: Unable to query device: -5

Signed-off-by: David Heidelberg <david@...t.cz>
---
 drivers/input/mouse/synaptics.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c
index ffad142801b3..ffb13055c7dc 100644
--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -1668,7 +1668,7 @@ static int __synaptics_init(struct psmouse *psmouse, bool absolute_mode)
 
 	error = synaptics_query_hardware(psmouse, &info);
 	if (error) {
-		psmouse_err(psmouse, "Unable to query device: %d\n", error);
+		psmouse_warn(psmouse, "Unable to query device: %d\n", error);
 		return error;
 	}
 
@@ -1824,7 +1824,7 @@ int synaptics_init_smbus(struct psmouse *psmouse)
 
 	error = synaptics_query_hardware(psmouse, &info);
 	if (error) {
-		psmouse_err(psmouse, "Unable to query device: %d\n", error);
+		psmouse_warn(psmouse, "Unable to query device: %d\n", error);
 		return error;
 	}
 
@@ -1864,7 +1864,7 @@ int synaptics_init(struct psmouse *psmouse)
 
 	error = synaptics_query_hardware(psmouse, &info);
 	if (error) {
-		psmouse_err(psmouse, "Unable to query device: %d\n", error);
+		psmouse_warn(psmouse, "Unable to query device: %d\n", error);
 		return error;
 	}
 
-- 
2.34.1