linux-kernel - Re: [PATCH v2 3/5] ARM: dts: at91: Use the generic "rtc" node name for the rtt IPs

Open Source and information security mailing list archives

Date:   Fri, 4 Mar 2022 11:13:35 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <Sergiu.Moga@...rochip.com>, <a.zummo@...ertech.it>,
        <alexandre.belloni@...tlin.com>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski@...onical.com>, <Nicolas.Ferre@...rochip.com>,
        <Claudiu.Beznea@...rochip.com>
CC:     <linux-rtc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/5] ARM: dts: at91: Use the generic "rtc" node name
 for the rtt IPs

On 3/3/22 16:06, Sergiu Moga wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> As the DT specification recommends, the node names should be of a
> generic nature. Thus, the most appropriate generic node name for
> the at91 rtt IPs is the "rtc" node name.
> 
> Signed-off-by: Sergiu Moga <sergiu.moga@...rochip.com>

Reviewed-by: Tudor Ambarus <tudor.ambarus@...rochip.com>

> ---
>  arch/arm/boot/dts/sam9x60.dtsi | 2 +-
>  arch/arm/boot/dts/sama7g5.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sam9x60.dtsi b/arch/arm/boot/dts/sam9x60.dtsi
> index 57ba47c54043..af7602cb65f7 100644
> --- a/arch/arm/boot/dts/sam9x60.dtsi
> +++ b/arch/arm/boot/dts/sam9x60.dtsi
> @@ -688,7 +688,7 @@ shutdown_controller: shdwc@...ffe10 {
>                                 status = "disabled";
>                         };
> 
> -                       rtt: rtt@...ffe20 {
> +                       rtt: rtc@...ffe20 {
>                                 compatible = "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt";
>                                 reg = <0xfffffe20 0x20>;
>                                 interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
> diff --git a/arch/arm/boot/dts/sama7g5.dtsi b/arch/arm/boot/dts/sama7g5.dtsi
> index 1530d88ce80f..87af6c680322 100644
> --- a/arch/arm/boot/dts/sama7g5.dtsi
> +++ b/arch/arm/boot/dts/sama7g5.dtsi
> @@ -133,7 +133,7 @@ shdwc: shdwc@...1d010 {
>                         status = "disabled";
>                 };
> 
> -               rtt: rtt@...1d020 {
> +               rtt: rtc@...1d020 {
>                         compatible = "microchip,sama7g5-rtt", "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt";
>                         reg = <0xe001d020 0x30>;
>                         interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_HIGH>;
> --
> 2.25.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives