linux-kernel - Re: [PATCH] lib/Kconfig.debug: add ARCH dependency for FUNCTION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220304021100.GN4548@shbuild999.sh.intel.com>
Date:   Fri, 4 Mar 2022 10:11:00 +0800
From:   Feng Tang <feng.tang@...el.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        kernel test robot <lkp@...el.com>,
        linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        Guo Ren <guoren@...nel.org>
Subject: Re: [PATCH] lib/Kconfig.debug: add ARCH dependency for
 FUNCTION_ALIGN option

On Thu, Mar 03, 2022 at 05:45:50PM -0800, Andrew Morton wrote:
> On Thu,  3 Mar 2022 16:20:48 +0800 Feng Tang <feng.tang@...el.com> wrote:
> 
> > 0Day robots reported there is compiling issue for 'csky' ARCH
> > when CONFIG_DEBUG_FORCE_DATA_SECTION_ALIGNED is enabled [1]:
> > 
> > ...
> >
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -401,8 +401,8 @@ config SECTION_MISMATCH_WARN_ONLY
> >  	  If unsure, say Y.
> >  
> >  config DEBUG_FORCE_FUNCTION_ALIGN_64B
> > -	bool "Force all function address 64B aligned" if EXPERT
> > -	depends on PPC || ARM || X86
> 
> I cannot find a kernel which contains the above line?

Sorry. I generated the patch while forgetting to revert the older version
https://lore.kernel.org/lkml/20220228022022.GG4548@shbuild999.sh.intel.com/

Here is the correct versin, thanks!

---

>From 817dca1a74778979ba71ed362eac36feab5ac112 Mon Sep 17 00:00:00 2001
From: Feng Tang <feng.tang@...el.com>
Date: Fri, 4 Mar 2022 10:03:40 +0800
Subject: [PATCH] lib/Kconfig.debug: add ARCH dependency for FUNCTION_ALIGN
 option

0Day robots reported there is compiling issue for 'csky' ARCH
when CONFIG_DEBUG_FORCE_DATA_SECTION_ALIGNED is enabled [1]:

"
All errors (new ones prefixed by >>):

   {standard input}: Assembler messages:
>> {standard input}:2277: Error: pcrel offset for branch to .LS000B too far (0x3c)
"

Which has been discussed in [2]. And as there is no solution for csky
yet, add some dependency for this config to limit it to several ARCHs
which have no compiling issue so far.

[1]. https://lore.kernel.org/lkml/202202271612.W32UJAj2-lkp@intel.com/
[2]. https://www.spinics.net/lists/linux-kbuild/msg30298.html

Reported-by: kernel test robot <lkp@...el.com>
Cc: Guo Ren <guoren@...nel.org>
Signed-off-by: Feng Tang <feng.tang@...el.com>
---
 lib/Kconfig.debug | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 14b89aa37c5c..440fd666c16d 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -416,7 +416,8 @@ config SECTION_MISMATCH_WARN_ONLY
 	  If unsure, say Y.
 
 config DEBUG_FORCE_FUNCTION_ALIGN_64B
-	bool "Force all function address 64B aligned" if EXPERT
+	bool "Force all function address 64B aligned"
+	depends on EXPERT && (X86_64 || ARM64 || PPC32 || PPC64 || ARC)
 	help
 	  There are cases that a commit from one domain changes the function
 	  address alignment of other domains, and cause magic performance
-- 
2.27.0