linux-kernel - Re: [PATCH 05/16] mm/migration: fix the confusing PageTransHuge check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZfGtVrbciBcCzAnNu85Gu3SEuEZf0fCRWEi4C2uT==80M_tA@mail.gmail.com>
Date:   Fri, 4 Mar 2022 20:20:47 +0800
From:   Muchun Song <songmuchun@...edance.com>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Yang Shi <shy828301@...il.com>,
        Matthew Wilcox <willy@...radead.org>,
        Huang Ying <ying.huang@...el.com>, Zi Yan <ziy@...dia.com>,
        Minchan Kim <minchan@...nel.org>,
        Alistair Popple <apopple@...dia.com>,
        ave.hansen@...ux.intel.com, o451686892@...il.com,
        Mina Almasry <almasrymina@...gle.com>,
        John Hubbard <jhubbard@...dia.com>,
        Ralph Campbell <rcampbell@...dia.com>,
        Peter Xu <peterx@...hat.com>,
        HORIGUCHI NAOYA(堀口 直也) 
        <naoya.horiguchi@....com>, Michal Hocko <mhocko@...e.com>,
        riel@...hat.com, Linux Memory Management List <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 05/16] mm/migration: fix the confusing PageTransHuge check

On Fri, Mar 4, 2022 at 5:35 PM Miaohe Lin <linmiaohe@...wei.com> wrote:
>
> prep_transhuge_page should be called when PageTransHuge(page) is true.
> The newly allocated new_page is not yet PageTransHuge though it could
> pass the check as PageTransHuge only checks PageHead now.
>
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

At least I agree with you.

Reviewed-by: Muchun Song <songmuchun@...edance.com>