linux-kernel - Re: Re: [PATCH] ASoC: wm8350: Handle error for wm8350_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220304024112.391990-1-jiasheng@iscas.ac.cn>
Date:   Fri,  4 Mar 2022 10:41:12 +0800
From:   Jiasheng Jiang <jiasheng@...as.ac.cn>
To:     ckeepax@...nsource.cirrus.com
Cc:     lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz,
        tiwai@...e.com, patches@...nsource.cirrus.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        Jiasheng Jiang <jiasheng@...as.ac.cn>
Subject: Re: Re: [PATCH] ASoC: wm8350: Handle error for wm8350_register_irq

On Thu, Mar 03, 2022 at 09:38:34PM +0800, Charles Keepax wrote:
>>  	if (ret != 0)
>> -		return ret;
>> +		goto err;
> 
> I would probably just leave this as a return, nothing is gained
> changing it to a goto.
> 
>>  
>> +	ret = wm8350_register_irq(wm8350, WM8350_IRQ_CODEC_JCK_DET_R,
>>  			    wm8350_hpr_jack_handler, 0, "Right jack detect",
>>  			    priv);
>> -	wm8350_register_irq(wm8350, WM8350_IRQ_CODEC_MICSCD,
>> +	if (ret != 0)
>> +		goto free_JCK_DET_L;
> 
> Probably better to use non-caps here, having caps in a label is a
> little unusual.

Thansk, I have submitted v2 to solve the problems.

Jiang