linux-kernel - Re: [PATCH 0/3] x86/PCI: Clip only partial E820 overlaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Mar 2022 15:15:16 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Bjorn Helgaas <helgaas@...nel.org>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>
Cc:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Myron Stowe <myron.stowe@...hat.com>,
        Juha-Pekka Heikkila <juhapekka.heikkila@...il.com>,
        Benoit Grégoire <benoitg@...us.ca>,
        Hui Wang <hui.wang@...onical.com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        linux-acpi@...r.kernel.org, linux-pci@...r.kernel.org,
        x86@...nel.org, linux-kernel@...r.kernel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH 0/3] x86/PCI: Clip only partial E820 overlaps

Hi Bjorn,

On 3/4/22 04:51, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> This is based on Hans' extensive debugging and patch at
> https://lore.kernel.org/r/20220228105259.230903-1-hdegoede@redhat.com
> and applies on 7e57714cd0ad ("Linux 5.17-rc6").
> 
> This is basically the same idea (applying the 4dc2287c1805 workaround only
> when an E820 region *partially* overlaps a host bridge window), but I think
> it's a little simpler.
> 
> This also adds a little dmesg output when clipping, which should make
> future debugging easier.
> 
> I bcc'd several folks who didn't have public email addresses in the RedHat
> bugzilla or Launchpad.  If you review or test this, I'd be happy to
> acknowledge that.
> 
> Bjorn Helgaas (3):
>   x86/PCI: Eliminate remove_e820_regions() common subexpressions
>   x86/PCI: Log host bridge window clipping for E820 regions
>   x86/PCI: Preserve host bridge windows completely covered by E820

Thanks, I agree that this is better then my fix I also like the logging
added to 2/3 which lets us know if the commit 4dc2287c1805 workaround
is active.

I have one small remark on 3/3. Regardless of that getting addressed
the entire series is:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

I've done a Fedora test kernel build of 5.16.12 with these 3 patches
added and asked the reporters of:

https://bugzilla.redhat.com/show_bug.cgi?id=1868899
(ideapad touchpad bug)

and:

https://bugzilla.redhat.com/show_bug.cgi?id=2029207
(Lenovo x1 carbon gen 2 regression with my bios-data based fix_

to test the rpms and to collect dmesg. On the X1C2 this should show
the new logging from 2/3 "in action" and on the ideapad the touchpad
should still work...

Regards,

Hans