linux-kernel - Re: [PATCH v3 4/5] dt-bindings: rtc: at91: Use macros for the IRQ type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 4 Mar 2022 15:52:00 +0000
From:   <Sergiu.Moga@...rochip.com>
To:     <krzysztof.kozlowski@...onical.com>, <a.zummo@...ertech.it>,
        <alexandre.belloni@...tlin.com>, <robh+dt@...nel.org>,
        <Nicolas.Ferre@...rochip.com>, <Claudiu.Beznea@...rochip.com>
CC:     <linux-rtc@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 4/5] dt-bindings: rtc: at91: Use macros for the IRQ
 type

On 04.03.2022 16:44, Krzysztof Kozlowski wrote:
> On 04/03/2022 15:27, Sergiu Moga wrote:
>> Prefer using macros for the IRQ type of the example node's
>> interrupt property.
>>
>> Signed-off-by: Sergiu Moga <sergiu.moga@...rochip.com>
>> ---
>>   Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml b/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
>> index af25cc275356..d2452067bfe4 100644
>> --- a/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
>> +++ b/Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
>> @@ -54,10 +54,12 @@ unevaluatedProperties: false
>>
>>   examples:
>>     - |
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +
>>       rtc@...ffd20 {
>>           compatible = "atmel,at91sam9260-rtt";
>>           reg = <0xfffffd20 0x10>;
>> -        interrupts = <1 4 7>;
>> +        interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
> Ah, I see the change now. This should be squashed with previous patch.
> There is no point to add imperfect DTS code which is being changed a
> commit later. Example is not bindings.
>
> Best regards,
> Krzysztof

Understood, I will make the squash for the next version. Thank you very 
much for the feedback.

Sergiu