linux-kernel - Re: [PATCH 2/4 v3] tracing: Add sample code for custom trace events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220304111226.264c7ae2@gandalf.local.home>
Date:   Fri, 4 Mar 2022 11:12:26 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Joel Fernandes <joel@...lfernandes.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Tom Zanussi <zanussi@...nel.org>
Subject: Re: [PATCH 2/4 v3] tracing: Add sample code for custom trace events

On Sat, 5 Mar 2022 01:09:30 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> > --- a/arch/x86/kernel/kprobes/core.c
> > +++ b/arch/x86/kernel/kprobes/core.c
> > @@ -202,8 +202,10 @@ __recover_probed_insn(kprobe_opcode_t *buf, unsigned long addr)
> >  	 * arch_check_ftrace_location(). Something went terribly wrong
> >  	 * if such an address is checked here.
> >  	 */
> > -	if (WARN_ON(faddr && faddr != addr))
> > +	if (WARN_ON(faddr && faddr != addr)) {
> > +		printk("faddr=%pS (%lx) addr=%pS (%lx)\n", (void*)faddr, faddr, (void*)addr, addr);
> >  		return 0UL;
> > +	}  
> 
> This part seems not related to this patch.
> Can you drop this?

Ug, yeah. Thanks for spotting this. This was used to help debug the IBT
code from Peter Z. I didn't even notice it.

-- Steve