linux-kernel - Re: [PATCH] net: qlogic: check the return value of dma_alloc_coherent() in qed_vf_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b9805786-d322-23b6-6a19-0e331b8957fe@gmail.com>
Date:   Sat, 5 Mar 2022 16:37:21 +0800
From:   Jia-Ju Bai <baijiaju1990@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     aelior@...vell.com, manishc@...vell.com, davem@...emloft.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: qlogic: check the return value of
 dma_alloc_coherent() in qed_vf_hw_prepare()



On 2022/3/4 13:19, Jakub Kicinski wrote:
> On Wed,  2 Mar 2022 19:34:50 -0800 Jia-Ju Bai wrote:
>> --- a/drivers/net/ethernet/qlogic/qed/qed_vf.c
>> +++ b/drivers/net/ethernet/qlogic/qed/qed_vf.c
>> @@ -513,6 +513,9 @@ int qed_vf_hw_prepare(struct qed_hwfn *p_hwfn)
>>   						    p_iov->bulletin.size,
>>   						    &p_iov->bulletin.phys,
>>   						    GFP_KERNEL);
>> +	if (!p_iov->bulletin.p_virt)
>> +		goto free_vf2pf_request;
> leaking the reply buffer

Hi Jakub,

Thanks for pointing out this problem.
I will send a V2 patch.


Best wishes,
Jia-Ju Bai