linux-kernel - [PATCH -next] ASoC: amd: acp: signedness bug in acp-renoir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 5 Mar 2022 20:35:19 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <lgirdwood@...il.com>, <broonie@...nel.org>, <perex@...ex.cz>,
        <tiwai@...e.com>, <AjitKumar.Pandey@....com>,
        <tangmeng@...ontech.com>
CC:     <alsa-devel@...a-project.org>, <linux-kernel@...r.kernel.org>,
        YueHaibing <yuehaibing@...wei.com>
Subject: [PATCH -next] ASoC: amd: acp: signedness bug in acp-renoir

In renoir_audio_probe() platform_get_irq_byname() may return error,
but i2s_irq now is unsigned int so the error handling is never triggered.

Fixes: 3304a242f45a ("ASoC: amd: Use platform_get_irq_byname() to get the interrupt")
Signed-off-by: YueHaibing <yuehaibing@...wei.com>
---
 sound/soc/amd/acp/amd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/amd/acp/amd.h b/sound/soc/amd/acp/amd.h
index 8fd38bf4d3bd..acb50d9fca58 100644
--- a/sound/soc/amd/acp/amd.h
+++ b/sound/soc/amd/acp/amd.h
@@ -96,7 +96,7 @@ struct acp_dev_data {
 	char *name;
 	struct device *dev;
 	void __iomem *acp_base;
-	unsigned int i2s_irq;
+	int i2s_irq;
 
 	/* SOC specific dais */
 	struct snd_soc_dai_driver *dai_driver;
-- 
2.17.1