linux-kernel - Re: [PATCH 1/6] KVM: fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d6d9aada7bba49b10e0abb0b1bc75bc43643d24.camel@perches.com>
Date:   Sat, 05 Mar 2022 12:34:53 -0800
From:   Joe Perches <joe@...ches.com>
To:     Henry Sloan <henryksloan@...il.com>
Cc:     pbonzini@...hat.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] KVM: fix checkpatch warnings

On Sat, 2022-03-05 at 15:26 -0500, Henry Sloan wrote:
> Fix "SPDX comment style" warnings

Hi.

You've given all these patches the same email subject line.

That would mean the commit subject line would also be the same
for each of these 6 patches.

That's bad.

More proper would be to use the first line of each commit
message as part of the subject line

i.e.: This subject line would become:

Subject: [PATCH 1/6] KVM: Fix "SPDX comment style" warnings

or perhaps better:

Subject: [PATCH 1/6] KVM: Use typical SPDX comment style

etc...

> 
> This patchset fixes many checkpatch warnings in the virt/kvm directory.

And this bit doesn't belong in the first patch of 6, but in a 0/6
patch cover letter.

cheers, Joe