linux-kernel - Re: [PATCH] clocksource/timer-imx-tpm: define tpm_read_sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <708ef23d-0c4a-47b5-dfe1-c55df9ccbf4b@linaro.org>
Date:   Sat, 5 Mar 2022 23:30:59 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     trix@...hat.com, tglx@...utronix.de, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        linux-imx@....com
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] clocksource/timer-imx-tpm: define tpm_read_sched_clock()
 conditionally for arm


Hi,

thanks for your patch.

It was already fixed by:

https://lore.kernel.org/r/20220303184212.2356245-1-nathan@kernel.org


On 05/03/2022 21:56, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> On aarch64 allyesconfig there is this error
> timer-imx-tpm.c:78:20: error: 'tpm_read_sched_clock'
>    defined but not used [-Werror=unused-function]
>     78 | static u64 notrace tpm_read_sched_clock(void)
>        |                    ^~~~~~~~~~~~~~~~~~~~
> 
> tpm_read_sched_clock() is only used conditionally
> for arm.  So also define conditionally for arm.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>   drivers/clocksource/timer-imx-tpm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/timer-imx-tpm.c b/drivers/clocksource/timer-imx-tpm.c
> index 60cefc247b715..bd64a8a8427f3 100644
> --- a/drivers/clocksource/timer-imx-tpm.c
> +++ b/drivers/clocksource/timer-imx-tpm.c
> @@ -73,12 +73,12 @@ static unsigned long tpm_read_current_timer(void)
>   {
>   	return tpm_read_counter();
>   }
> -#endif
>   
>   static u64 notrace tpm_read_sched_clock(void)
>   {
>   	return tpm_read_counter();
>   }
> +#endif
>   
>   static int tpm_set_next_event(unsigned long delta,
>   				struct clock_event_device *evt)


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog