linux-kernel - [PATCH linux-next] cgroup: fix suspicious rcu_dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220305034103.57123-1-zhouchengming@bytedance.com>
Date:   Sat,  5 Mar 2022 11:41:03 +0800
From:   Chengming Zhou <zhouchengming@...edance.com>
To:     tj@...nel.org, lizefan.x@...edance.com, hannes@...xchg.org,
        peterz@...radead.org
Cc:     cgroups@...r.kernel.org, linux-kernel@...r.kernel.org,
        songmuchun@...edance.com,
        Chengming Zhou <zhouchengming@...edance.com>,
        Linux Kernel Functional Testing <lkft@...aro.org>,
        syzbot+16e3f2c77e7c5a0113f9@...kaller.appspotmail.com,
        Zhouyi Zhou <zhouzhouyi@...il.com>
Subject: [PATCH linux-next] cgroup: fix suspicious rcu_dereference_check() usage warning

task_css_set_check() will use rcu_dereference_check() to check for
rcu_read_lock_held() on the read-side, which is not true after commit
dc6e0818bc9a ("sched/cpuacct: Optimize away RCU read lock"). This
commit drop explicit rcu_read_lock(), change to RCU-sched read-side
critical section. So fix the RCU warning by adding check for
rcu_read_lock_sched_held().

Fixes: dc6e0818bc9a ("sched/cpuacct: Optimize away RCU read lock")
Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
Reported-by: syzbot+16e3f2c77e7c5a0113f9@...kaller.appspotmail.com
Tested-by: Zhouyi Zhou <zhouzhouyi@...il.com>
Signed-off-by: Chengming Zhou <zhouchengming@...edance.com>
---
 include/linux/cgroup.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index 1e356c222756..0d1ada8968d7 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -450,6 +450,7 @@ extern struct mutex cgroup_mutex;
 extern spinlock_t css_set_lock;
 #define task_css_set_check(task, __c)					\
 	rcu_dereference_check((task)->cgroups,				\
+		rcu_read_lock_sched_held() ||				\
 		lockdep_is_held(&cgroup_mutex) ||			\
 		lockdep_is_held(&css_set_lock) ||			\
 		((task)->flags & PF_EXITING) || (__c))
-- 
2.20.1