linux-kernel - Re: [PATCH v2] net: cxgb3: Fix an error code when probing the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YiTP/t65qhhBaKvf@lunn.ch>
Date:   Sun, 6 Mar 2022 16:15:10 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Zheyu Ma <zheyuma97@...il.com>
Cc:     rajur@...lsio.com, davem@...emloft.net, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: cxgb3: Fix an error code when probing the driver

On Sun, Mar 06, 2022 at 05:56:32AM +0000, Zheyu Ma wrote:
> During the process of driver probing, probe function should return < 0
> for failure, otherwise kernel will treat value >= 0 as success.
> 
> Therefore, the driver should set 'err' to -ENODEV when
> 'adapter->registered_device_map' is NULL. Otherwise kernel will assume
> that the driver has been successfully probed and will cause unexpected
> errors.
> 
> Signed-off-by: Zheyu Ma <zheyuma97@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew