linux-kernel - RE: [PATCH] exfat: do not clear VolumeDirty in writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <TYAPR01MB53536D7149FDB6A9ABBD8F5090089@TYAPR01MB5353.jpnprd01.prod.outlook.com>
Date:   Mon, 7 Mar 2022 05:34:17 +0000
From:   "Kohada.Tetsuhiro@...MitsubishiElectric.co.jp" 
        <Kohada.Tetsuhiro@...MitsubishiElectric.co.jp>
To:     unlisted-recipients:; (no To-header on input)
CC:     "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "sj1557.seo@...sung.com" <sj1557.seo@...sung.com>
Subject: RE: [PATCH] exfat: do not clear VolumeDirty in writeback

Hi, Yuezhang,Mo

> > >(PS: The original logic is to clear VolumeDirty after BitMap, FAT and directory
> > entries are updated.)
> >
> > However, the writing order was not guaranteed.
> > More synchronous writes are needed to guarantee the write order.
> 
> If "dirsync" or "sync" is enabled, BitMap, FAT and directory entries are guaranteed to be written in order.
> This is the reason to keep clearing VolumeDirty.

SB_DIRSYNC requests synchronization of the inode of the current file/dir.
The exfat implementation updates and syncs the dir-entries of the current file/dir.
If only SB_DIRSYNC is set and SB_SYNC is not set, it cannot be guaranteed that FAT/mirrorFAT is synchronized.

BR
T .Kohada