linux-kernel - Re: [PATCH] MIPS: Sanitise Cavium switch cases in TLB handler synthesizers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220307122117.GD14422@alpha.franken.de>
Date:   Mon, 7 Mar 2022 13:21:17 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     "Maciej W. Rozycki" <macro@...am.me.uk>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: Sanitise Cavium switch cases in TLB handler
 synthesizers

On Fri, Mar 04, 2022 at 09:13:11PM +0000, Maciej W. Rozycki wrote:
> It makes no sense to fall through to `break'.  Therefore reorder the 
> switch statements so as to have the Cavium cases first, followed by the 
> default case, which improves readability and pacifies code analysis 
> tools.  No change in semantics, assembly produced is exactly the same.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Maciej W. Rozycki <macro@...am.me.uk>
> Fixes: bc431d2153cc ("MIPS: Fix fall-through warnings for Clang")
> ---
>  arch/mips/mm/tlbex.c |   23 ++++++++++-------------
>  1 file changed, 10 insertions(+), 13 deletions(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]